Skip to content

fix: add accessible labels to search and newsletter inputs - #10

Merged
royalpinto007 merged 2 commits into
AgentPostmortem:mainfrom
slegarraga:fix/search-newsletter-accessible-labels
Aug 6, 2026
Merged

fix: add accessible labels to search and newsletter inputs#10
royalpinto007 merged 2 commits into
AgentPostmortem:mainfrom
slegarraga:fix/search-newsletter-accessible-labels

Conversation

@slegarraga

Copy link
Copy Markdown
Contributor

Adds explicit programmatic labels to the two text inputs that previously relied on placeholders or adjacent visible text.

  • Search input now has a screen-reader-only label and an id.
  • Newsletter input now associates its visible label with the field.

Verified with npm run lint and npx tsc --noEmit.

Closes #3

@royalpinto007

Copy link
Copy Markdown
Contributor

Thanks a lot for this, @slegarraga, and welcome!

This is exactly the right fix. Associating the newsletter label with htmlFor/id and giving the search input a proper sr-only label means screen readers announce both correctly, rather than relying on placeholder text or nearby visible text. Nicely scoped, and all checks are green.

Merging now. If you enjoyed this one, there are a couple more open good first issue items (a real URL bug in CopyLinkButton, and a docs gap in CONTRIBUTING) and you would be very welcome to take either.

@royalpinto007
royalpinto007 merged commit 841d997 into AgentPostmortem:main Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: search and newsletter inputs have no accessible label

2 participants