docs/fpi-bug: Miden Bank tutorial's "get_balance" and "deposit" method names collide with core library on v0.15.3

[anaraydinli55]

Documentation Issue / Namespace Collision

While building the official Miden Bank tutorial using the latest mainnet toolchain (v0.15.3 and miden-base v0.13.1), I encountered a namespace collision and linker errors when compiling the deposit-note (or other cross-component FPI notes).

The original tutorial uses:

1. deposit method on the Bank account.
2. get_balance method on the Bank account.

The Conflict

On v0.15.3, the #[account(bank_account::BankAccount)] macro expands into FPI bindings. However:

1. The deposit function name collides with the built-in standard library's BasicWallet deposit method.
2. The get_balance function name collides with the built-in ActiveAccount's get_balance method, throwing the following error during wasm-component-ld linking:
   error: dependency function get-balance collides with the built-in ActiveAccount method get_balance; the generated wrapper method would shadow it. Rename the dependency function

The Solution

To successfully compile the Miden Bank tutorial on the new mainnet toolchain:

• Rename the deposit method to bank_deposit (or another unique name) in both the contract and the notes.
• Rename the get_balance method to check_balance in both the contract and the notes.

I suggest updating the official tutorial repository and documentation to reflect these v0.15.3 namespace rules.

Reproduction Repo

I have compiled, tested, and resolved this in my local workspace here:
🔗 https://github.com/anaraydinli55/miden-testnet-project

[huklaa]

I opened #238 with the minimal remaining fix on current main: rename the Bank account's exported deposit method to bank_deposit and update the deposit-note FPI call. The reported get_balance collision is already addressed upstream as get_depositor_balance, so I intentionally did not introduce a second rename there. The PR is kept draft until the fork-triggered Actions can run / the Miden build can be validated.

[anaraydinli55]

Thanks for addressing this!

I originally reported this issue in #237 after reproducing the collision while building the Miden Bank tutorial on v0.15.3.

I can confirm that renaming deposit to bank_deposit and updating the deposit-note FPI call addresses the remaining collision. The get_balance issue is already addressed upstream as get_depositor_balance.

Thanks for the focused fix!